Skip to content

HADOOP-18701. Generic Build Improvements.#5567

Closed
ayushtkn wants to merge 1 commit intoapache:trunkfrom
ayushtkn:HADOOP-18701
Closed

HADOOP-18701. Generic Build Improvements.#5567
ayushtkn wants to merge 1 commit intoapache:trunkfrom
ayushtkn:HADOOP-18701

Conversation

@ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Apr 18, 2023 •
edited
Loading

Description of PR

Attempting basic improvements

How was this patch tested?

Tried failIfNoSpecifiedTests prop by now

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus

This comment was marked as outdated.

Sign in to view
@hadoop-yetus
Copy link

hadoop-yetus commented Apr 19, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 16m 40s Maven dependency ordering for branch
+1 💚 mvninstall 25m 47s trunk passed
+1 💚 compile 23m 7s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 20m 36s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 mvnsite 25m 22s trunk passed
+1 💚 javadoc 8m 7s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 15s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 34m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 41s Maven dependency ordering for patch
+1 💚 mvninstall 22m 34s the patch passed
+1 💚 compile 22m 28s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 22m 28s the patch passed
+1 💚 compile 20m 41s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 javac 20m 41s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 19m 53s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 7m 50s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 21s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 35m 58s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 567m 37s /patch-unit-root.txt root in the patch failed.
+0 🆗 asflicense 0m 49s ASF License check generated no output?
841m 18s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5567/3/artifact/out/Dockerfile
GITHUB PR #5567
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs compile javac javadoc mvninstall mvnsite unit shadedclient xmllint
uname Linux 2f9dad57855b 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 6abf97b
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5567/3/testReport/
Max. process+thread count 3098 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5567/3/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran added a commit to steveloughran/hadoop that referenced this pull request Jul 17, 2025
@steveloughran
HADOOP-19608. Upgrade to Junit 5.13.3
24019ca 
pick up changes of apache#5567 to pull out setting of stack trace
and failIfNoSpecifiedTests to build properties with our
chosen values.
steveloughran added a commit to steveloughran/hadoop that referenced this pull request Jul 22, 2025
@steveloughran
HADOOP-19608. Upgrade to Junit 5.13.3
b8a0554 
pick up changes of apache#5567 to pull out setting of stack trace
and failIfNoSpecifiedTests to build properties with our
chosen values.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

@github-actions github-actions bot added the Stale label Oct 23, 2025
@github-actions github-actions bot closed this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ayushtkn @hadoop-yetus